fix(seer grouping): Stop checking for missing groups when handling processed results #70670
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When Seer sends back information on similar groups, there's no guarantee that those groups still exist on the Sentry side. Therefore, in the similar issues endpoint, we surround our code which handles the Seer results with a
try-except
, in case we look for a group which isn't there. Now that the Seer data is first being processed by theSeerSimilarIssueData.from_raw
factory method, though, we no longer have to worry about missing groups, becausefrom_raw
will error out and not create aSeerSimilarIssueData
instance if the group doesn't exist.This therefore removes the
try-except
, which then allows us to use a simple list comprehension to build the return value of the endpoint'sget_formatted_results
helper.