ref(seer grouping): SeerSimilarIssueData.from_raw improvements
#70668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
lobsterkatie
force-pushed
the
kmclb-add-dictionary-filter-helper
branch
from
f1cf889
to
05955be
Compare
lobsterkatie
force-pushed
the
kmclb-seer-data-from_raw-improvements
branch
from
db22d42
to
3d4e03a
Compare
JoshFerge
reviewed
May 14, 2024
src/sentry/seer/utils.py
Outdated
Comment on lines
148
to
150
| required_keys = {"stacktrace_distance", "message_distance", "should_group"} | ||
| optional_keys = {"parent_hash", "parent_group_id"} | ||
| expected_keys = {*required_keys, *optional_keys} |
There was a problem hiding this comment.
nit: since these are constants, you could pull them out of the function to be on the class / a constant at top of file.
JoshFerge
approved these changes
May 14, 2024
lobsterkatie
force-pushed
the
kmclb-seer-data-from_raw-improvements
branch
from
3d4e03a
to
33cd705
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #70668 +/- ##
=======================================
Coverage 80.02% 80.03%
=======================================
Files 6508 6508
Lines 291198 291270 +72
Branches 50202 50200 -2
=======================================
+ Hits 233028 233104 +76
+ Misses 57736 57732 -4
Partials 434 434
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes a number of improvements to the
from_raw1 factory method in theSeerSimilarIssueData` dataclass, all related to the fact that the data being fed to it comes straight from the JSON returned by Seer and so we can't actually guarantee what's in it.Included changes:
raw_similar_issue_dataparameter, fromRawSeerSimilarIssueData(implying we know exactly what's in it) toMapping[str, Any](acknowledging that we don't).SeerSimilarIssueDataconstructor from crashing with an 'unknown keyword argument' error in the case of unexpected data.