ref(js): Use useLocation in useUrlParams

[evanpurkhiser]

Newer versions of the history library do not support this function 0.
Use useLocation in this case instead.

[codecov]

Bundle Report

Changes will decrease total bundle size by 9 bytes ⬇️

Bundle name	Size	Change
app-webpack-bundle-array-push	26.77MB	9 bytes ⬇️

[evanpurkhiser]

This does appear to break things in a weird way.

it's broken

[evanpurkhiser]

Okay so this is only broken in places where we're making synchronous calls to multiple uses of this hook

Specifically here

sentry/static/app/views/replays/detail/network/useSortNetwork.tsx

Lines 53 to 64 in 531b2f2

	const handleSort = useCallback(
	(fieldName: keyof typeof SortStrategies) => {
	if (sortConfig.by === fieldName) {
	setSortAsc(sortConfig.asc ? 'false' : 'true');
	} else {
	setSortAsc('true');
	setSortBy(fieldName);
	}
	setDetailRow('');
	},
	[sortConfig, setSortAsc, setSortBy, setDetailRow]
	);

We can't do this when using useLocation because each subsequent call will not have the new value of the location object, so it will remove values updated in the query string by the previous calls.

Not sure what the right fix is yet.