feat(onboarding): Add hapi, fastify and Nest.js #70647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
s1gr1d
force-pushed
the
sig/onboarding-hapi-fastify-nestjs
branch
from
0a0569f
to
dc2ae99
Compare
Updates the code snippets to show the new serverless packages for aws and gcp.
For JS SDK v8 an external file is needed to initialize the SDK right at the start of the application. The existing node guides are updated. --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Improve tests for onboarding pages to make sure the profiling import is present and the correct error handler is used.
s1gr1d
force-pushed
the
sig/onboarding-hapi-fastify-nestjs
branch
from
65056c4
to
fead1c8
Compare
mydea
reviewed
May 17, 2024
Comment on lines
25
to
26
|
|
||
| import * as Sentry from '@sentry/node'; |
There was a problem hiding this comment.
Suggested change
| import * as Sentry from '@sentry/node'; | |
| // All other imports below | |
| import * as Sentry from '@sentry/node'; |
let's add a comment like this, this ensures this is not reordered e.g. by vscode!
Bundle ReportChanges will increase total bundle size by 104.6kB ⬆️
|
cmanallen
pushed a commit
that referenced
this pull request
May 21, 2024
Will merge this after v8 is out for a while (like 1 week or so). --------- Co-authored-by: getsantry[bot] <66042841+getsantry[bot]@users.noreply.github.com>
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will merge this after v8 is out for a while (like 1 week or so).