feat(crons): Add deletion apis for processing errors #70639
Conversation
github-actions
bot
added
the
Scope: Backend
wedamija
force-pushed
the
danf/crons-processing-error-data-storage
branch
from
2989743
to
6b9efe5
Compare
wedamija
force-pushed
the
danf/crons-processing-error-delete
branch
from
83589b8
to
e349d28
Compare
wedamija
force-pushed
the
danf/crons-processing-error-data-storage
branch
from
6b9efe5
to
026ba25
Compare
wedamija
force-pushed
the
danf/crons-processing-error-delete
branch
from
e349d28
to
54de3c7
Compare
|
If we want, we could just make this api per project as well, instead of having two separate ones |
| parsed_uuid = UUID(uuid) | ||
| except ValueError: | ||
| raise ValidationError("Invalid UUID") | ||
| CheckinProcessErrorsManager().delete_for_project(project, parsed_uuid) |
There was a problem hiding this comment.
I am starting to feel like maybe this should just be in it's own module lol nbd
There was a problem hiding this comment.
Yeah... Feels weird to instantiate it. What if I just make all the methods class/static?
There was a problem hiding this comment.
sgtm. I am good w/ a module too
could add a query parameter to filter to monitor slug? |
wedamija
force-pushed
the
danf/crons-processing-error-delete
branch
from
54de3c7
to
c9078d1
Compare
I can delete it without the monitor slug anyway. We only really have to delete the actually error, we don't have to delete from the index since it'll just drop any errors that don't have values. But I think I can also just get the monitor info from the stored processing error. Maybe it's better to just do that? |
This adds apis at both the monitor and project level for deleting checkin processing errors.
wedamija
force-pushed
the
danf/crons-processing-error-delete
branch
from
c9078d1
to
51a2b4c
Compare
This adds apis at both the monitor and project level for deleting checkin processing errors.