Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sdk): Enable query source logging #60649

Merged
merged 4 commits into from
Nov 29, 2023
Merged

Conversation

gggritso
Copy link
Member

@gggritso gggritso commented Nov 27, 2023

Dogfooding the query source feature. Conservatively sets the threshold to 500ms for now. If you're wondering about performance overhead for this, check out info in getsentry/sentry-python#2521

Conservatively sets the threshold to 500ms for now.
@gggritso gggritso requested a review from a team as a code owner November 27, 2023 21:46
@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Nov 27, 2023
Copy link

codecov bot commented Nov 27, 2023

Codecov Report

Merging #60649 (6a9f6d5) into master (8e8e2c5) will increase coverage by 1.21%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #60649      +/-   ##
==========================================
+ Coverage   79.69%   80.91%   +1.21%     
==========================================
  Files        5180     5181       +1     
  Lines      227024   227065      +41     
  Branches    38151    38152       +1     
==========================================
+ Hits       180925   183723    +2798     
+ Misses      40385    37734    -2651     
+ Partials     5714     5608     -106     
Files Coverage Δ
src/sentry/conf/server.py 90.01% <ø> (ø)
src/sentry/conf/types/sdk_config.py 100.00% <100.00%> (ø)

... and 251 files with indirect coverage changes

Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good :shipit:

@gggritso gggritso merged commit bdb2de7 into master Nov 29, 2023
50 checks passed
@gggritso gggritso deleted the chore/ggg/enable-query-source branch November 29, 2023 15:48
@github-actions github-actions bot locked and limited conversation to collaborators Dec 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants