feat: Add Spotlight

[HazAT]

Adds Spotlight to local Sentry

Google.Chrome.mp4

[github-actions]

🚨 Warning: This pull request contains Frontend and Backend changes!

It's discouraged to make changes to Sentry's Frontend and Backend in a single pull request. The Frontend and Backend are not atomically deployed. If the changes are interdependent of each other, they must be separated into two pull requests and be made forward or backwards compatible, such that the Backend or Frontend can be safely deployed independently.

Have questions? Please ask in the #discuss-dev-infra channel.

[codecov]

Codecov Report

Merging #60523 (40e1fa7) into master (927112b) will decrease coverage by 0.01%.
The diff coverage is n/a.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #60523      +/-   ##
==========================================
- Coverage   81.08%   81.08%   -0.01%     
==========================================
  Files        5186     5188       +2     
  Lines      227811   227974     +163     
  Branches    38221    38247      +26     
==========================================
+ Hits       184726   184847     +121     
- Misses      37459    37502      +43     
+ Partials     5626     5625       -1     

Files	Coverage Δ
src/sentry/conf/server.py	89.91% <ø> (ø)
src/sentry/utils/sdk.py	71.17% <ø> (ø)
static/app/bootstrap/initializeSdk.tsx	0.00% <ø> (ø)

... and 74 files with indirect coverage changes

[HazAT]

I still can find spotlight in the prod build cc @AbhiPrasad :(

[AbhiPrasad]

I still can find spotlight in the prod build cc @AbhiPrasad :(

Yeah this makes sense actually because of the sentryConfig.environment conditional, it can't be evaluated at bundle time, so even if sentryConfig.environment is marked as side effect free it'll be kept.

you'll have to do

if (process.env.NODE_ENV !== 'production') {
  if (sentryConfig.environment === 'development) {
    Spotlight.init();
  }
}

[scttcper]

if postcss, tailwind, etc are only used to build the package they should be moved to devDependencies and react 18 should be a peer dependency. if possible react-router-dom should be removed as well since we're not on v6

[dcramer]

Before we merge lets answer why we need ANY deps to load Spotlight.

My expectation is its ENTIRELY isolated, just like the CSS is, and should have zero conflicts.

Its ok to load a 2mb local JS package...

[HazAT]

@scttcper Thank you! The dependency problem has been resolved
That was critical for Spotlight

[HazAT]

I still can find spotlight in the prod build cc @AbhiPrasad :(

Yeah this makes sense actually because of the sentryConfig.environment conditional, it can't be evaluated at bundle time, so even if sentryConfig.environment is marked as side effect free it'll be kept.

you'll have to do

if (process.env.NODE_ENV !== 'production') {
  if (sentryConfig.environment === 'development) {
    Spotlight.init();
  }
}

@AbhiPrasad this worked!

[scttcper]

lookin good 👍

[asottile-sentry]

reverting: broke the build

yarn run v1.22.5
$ /workspace/node_modules/.bin/tsc -p config/tsconfig.build.json
static/app/bootstrap/initializeSdk.tsx(5,28): error TS2307: Cannot find module '@spotlightjs/spotlight' or its corresponding type declarations.
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[getsentry-bot]

PR reverted: 40da94a