-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(metrics): Track code locations for metrics #60514
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
Automatically applied to PRs that change backend components
label
Nov 23, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #60514 +/- ##
=======================================
Coverage 80.85% 80.85%
=======================================
Files 5185 5185
Lines 227935 227933 -2
Branches 38350 38350
=======================================
- Hits 184302 184301 -1
+ Misses 38006 38004 -2
- Partials 5627 5628 +1
|
obostjancic
approved these changes
Nov 24, 2023
sentrivana
approved these changes
Nov 24, 2023
Dav1dde
approved these changes
Nov 24, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for code locations in DDM metrics and updates all patched methods. The feature can be controlled at runtime through
delightful_metrics.enable_code_locations
via options-automator, and defaults to OFF.All metric capture methods of the various backends increment the internal stack level so that the caller's location is captured by the SDK. Additionally, the newly added
stacklevel
argument can be used to track callers further up the stack.Requires: getsentry/sentry-python#2526
Epic: #60260