Add support for symfony/psr-http-message-bridge: ^6.4
#750
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 24, 2023
|
I can confirm that this change works. I updated a Symfony app to 6.4 and used my own fork of |
|
Just tested as well and it works for me. |
stof
reviewed
Oct 28, 2023
Merged
nicolas-grekas
added a commit
to symfony/flex
that referenced
this pull request
Oct 30, 2023
… for versions before 6.4 (nicolas-grekas) This PR was merged into the 1.x branch. Discussion ---------- Decouple psr-http-message-bridge from extra.symfony.require for versions before 6.4 Should fix issues like getsentry/sentry-symfony#750 and symfony/recipes#1236 Before 6.4, the bridge was not in `symfony/symfony` so that `extra.symfony.require` shouldn't apply to earlier versions. We *could* improve the API and flex to handle this concern at a more generic level, but this is so rare that I suggest hard-coding the rule in flex. Commits ------- 42276be Decouple psr-http-message-bridge from extra.symfony.require for versions before 6.4
|
The root issue should be fixed by symfony/flex#1003, but this change is still welcome (I'd suggest merging + releasing without waiting for 6.4-stable, that might make things a big smoother for end users.) |
# Conflicts: # composer.json
cleptric
force-pushed
the
psr-http-message-bridge
branch
from
34ef34b
to
6677e77
Compare
ste93cry
approved these changes
Oct 30, 2023
|
Released in 4.12.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes #749 once Symfony 6.4 was tagged.