Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent crashes from get_main_hub when in trap context #2510

Conversation

solnic
Copy link
Collaborator

@solnic solnic commented Jan 16, 2025

Fixes #2495

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 98.16%. Comparing base (14ef446) to head (eaf2b30).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
sentry-ruby/lib/sentry-ruby.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2510      +/-   ##
==========================================
- Coverage   98.18%   98.16%   -0.02%     
==========================================
  Files         128      128              
  Lines        4846     4848       +2     
==========================================
+ Hits         4758     4759       +1     
- Misses         88       89       +1     
Components Coverage Δ
sentry-ruby 98.54% <0.00%> (-0.03%) ⬇️
sentry-rails 97.07% <ø> (ø)
sentry-sidekiq 97.09% <ø> (ø)
sentry-resque 92.85% <ø> (+0.10%) ⬆️
sentry-delayed_job 95.65% <ø> (ø)
sentry-opentelemetry 99.31% <ø> (ø)
Files with missing lines Coverage Δ
sentry-ruby/lib/sentry-ruby.rb 99.54% <0.00%> (-0.46%) ⬇️

... and 1 file with indirect coverage changes

@solnic solnic marked this pull request as ready for review January 16, 2025 14:04
@solnic solnic force-pushed the 2495-threaderror-resqueno_fork-resquework-new-level-error-unhandled-cant-be-called-from-trap-context-threaderror branch 3 times, most recently from 5fce129 to 474e5e8 Compare January 17, 2025 10:36

Verified

This commit was signed with the committer’s verified signature. The key has expired.
joachifm Joachim F.

Verified

This commit was signed with the committer’s verified signature. The key has expired.
joachifm Joachim F.
@solnic solnic force-pushed the 2495-threaderror-resqueno_fork-resquework-new-level-error-unhandled-cant-be-called-from-trap-context-threaderror branch from 474e5e8 to eaf2b30 Compare January 17, 2025 10:46
@solnic solnic merged commit 1cd952b into master Jan 17, 2025
146 of 148 checks passed
@solnic solnic deleted the 2495-threaderror-resqueno_fork-resquework-new-level-error-unhandled-cant-be-called-from-trap-context-threaderror branch January 17, 2025 10:52
@solnic
Copy link
Collaborator Author

solnic commented Jan 17, 2025

@sl0thentr0py I set the spec to run only under 3.4+ because it was randomly failing on older ones and jruby has no fork. This is such an edge case and hub's going away so it makes no sense to pay the price for running a complex repro test on all rubies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants