Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Get connection from connection_pool instead of ActiveRecord::Base.connection #2278

Merged

changelog

11a1f51
Select commit
Failed to load commit list.
Merged

Fix: Get connection from connection_pool instead of ActiveRecord::Base.connection #2278

changelog
11a1f51
Select commit
Failed to load commit list.
Codecov / codecov/project succeeded Mar 20, 2024 in 0s

97.64% (+0.02%) compared to 7d29d3c

View this Pull Request on Codecov

97.64% (+0.02%) compared to 7d29d3c

Details

Codecov Report

Merging #2278 (11a1f51) into master (7d29d3c) will increase coverage by 0.02%.
Report is 2 commits behind head on master.
The diff coverage is 0.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2278      +/-   ##
==========================================
+ Coverage   97.61%   97.64%   +0.02%     
==========================================
  Files         112      112              
  Lines        4155     4154       -1     
==========================================
  Hits         4056     4056              
+ Misses         99       98       -1     
Components Coverage Δ
sentry-ruby 98.30% <ø> (-0.04%) ⬇️
sentry-rails 95.22% <0.00%> (+0.17%) ⬆️
sentry-sidekiq 94.70% <ø> (ø)
sentry-resque 92.30% <ø> (+1.53%) ⬆️
sentry-delayed_job 95.60% <ø> (ø)
sentry-opentelemetry 100.00% <ø> (ø)
Files Coverage Δ
...b/sentry/rails/tracing/active_record_subscriber.rb 85.71% <0.00%> (+2.95%) ⬆️

... and 2 files with indirect coverage changes