fix: Don't mutate original enabled_environments #2275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2275 +/- ##
==========================================
- Coverage 97.61% 97.56% -0.05%
==========================================
Files 112 112
Lines 4154 4155 +1
==========================================
- Hits 4055 4054 -1
- Misses 99 101 +2
|
Ensure enabled_environments contains test environment without mutating original list. See: getsentry#2269 (comment)
ixti
force-pushed
the
ixti/fix-test-setup-helper
branch
from
ebf04a4
to
a573841
Compare
|
Thanks for the PR, but why did you find it necessary to freeze the |
|
My tests were randomly passing randomly failing. Adding a freeze helped to nail down that Sentry helper was changing configuration inplace - thus specs became order-dependent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure enabled_environments contains test environment without mutating original list. Otherwise it can cause unexpected spec failures in case original config has unfrozen Array, or fail in attempt to mutate said array.
Alternative approach would be to override
Sentry::Configuration#dupto dup underlying arrays and hashes.See: #2269 (comment)