Add metrics code locations #2263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add a `LocalAggregator` instance on spans to duplicate metrics on the span as a gauge metric * proxy the main aggregator add calls to the local aggregator if a span is running * start a `metrics.timing` span in the `Sentry::Metrics.timing` API
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2263 +/- ##
==========================================
+ Coverage 97.59% 97.61% +0.02%
==========================================
Files 112 112
Lines 4116 4153 +37
==========================================
+ Hits 4017 4054 +37
Misses 99 99
|
sl0thentr0py
force-pushed
the
neel/metrics/code-locations
branch
2 times, most recently
from
8909e86
to
24a65c7
Compare
sl0thentr0py
force-pushed
the
neel/metrics/code-locations
branch
from
24a65c7
to
4107fd4
Compare
cleptric
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
metric_metaconfig.metrics.enable_code_locations, defaults to truepart of #2246