Fix CI and simplify matrix #2230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| bundler: 1 | ||
| ruby-version: ${{ matrix.ruby_version }} | ||
| - name: Set up Ruby ${{ matrix.ruby_version }} | ||
| uses: ruby/setup-ruby@v1 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
| with: | ||
| redis-version: 5 | ||
| - name: Start Redis | ||
| uses: supercharge/redis-github-action@1.1.0 |
There was a problem hiding this comment.
- 🚫 Please pin the action by specifying a commit SHA instead of a tag/branch.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2230 +/- ##
=======================================
Coverage 97.44% 97.44%
=======================================
Files 102 102
Lines 3800 3800
=======================================
Hits 3703 3703
Misses 97 97
|
sl0thentr0py
approved these changes
Jan 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ubuntu-latest, I removedosfrom the matrix to simplify our workflow configs.sentry-delayed_jobstill tests againstRails 7.0, which doesn't work with Ruby head atm due tomutex_mgem being migrated to bundled gem:And I fixed it by excluding Ruby head from the matrix.
Ideally the fix should be to use Rails 7.1 for testing instead, but it's trickier than I thought. So I decided to fix it first and work on #2229 later.
#skip-changelog