Fix warning about default gems on Ruby 3.3.0 #2225
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-yagi
changed the title
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2225 +/- ##
==========================================
- Coverage 97.42% 97.42% -0.01%
==========================================
Files 102 102
Lines 3801 3800 -1
==========================================
- Hits 3703 3702 -1
Misses 98 98
|
Since Ruby 3.3.0, RubyGems and Bundler warn if users do require the gems that will become the bundled gems in the future version of Ruby. Please see the "Standard library updates" section for the details. https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/ `sentry-ruby` uses one of those gems, `bigdecimal`. So now get the warning like the following. https://github.com/getsentry/sentry-ruby/actions/runs/7463068254/job/20306920751#step:6:89 This PR adds `bigdecimal` to the gemspec to fix the warning.
Base64 has unused since 46384cd.
y-yagi
force-pushed
the
fix-warning-about-default-gems
branch
from
f7bb6be
to
92d14cf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since Ruby 3.3.0, RubyGems and Bundler warn if users do require the gems that will become the bundled gems in the future version of Ruby.
Please see the "Standard library updates" section for the details.
https://www.ruby-lang.org/en/news/2023/12/25/ruby-3-3-0-released/
sentry-rubyuses one of those gems,bigdecimal. So now get the warning like the following.https://github.com/getsentry/sentry-ruby/actions/runs/7463068254/job/20306920751#step:6:89
This PR adds
bigdecimalto the gemspec to fix the warning.This PR also removed unused require of
base64.base64is also the gem that will become the bundled gems. But, it seems thatsentry-rubydoesn't use it now. So I just removed it.