Require debug/prelude in spec helper
#2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the latest debug gem now require Ruby >= 2.7, if we require `debug` in older Rubies, it'll require a very outdated debug lib instead.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2273 +/- ##
==========================================
+ Coverage 97.41% 97.61% +0.20%
==========================================
Files 102 112 +10
Lines 3828 4155 +327
==========================================
+ Hits 3729 4056 +327
Misses 99 99
|
sl0thentr0py
approved these changes
Mar 17, 2024
st0012
changed the title
debug/prelude in spec helper
Requiring `debug` activates the debugger even when no breakpoints are hit. Although the chance is low, it may slow down the test suite and/or cause unexpected behavior. This change requires `debug/prelude` instead of `debug` to avoid the above issue while still allowing the use of breakpoints.
st0012
force-pushed
the
fix-debug-requires
branch
from
cd0581f
to
34c1f19
Compare
sl0thentr0py
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the latest debug gem now requires Ruby >= 2.7, if we require
debugin older Rubies, it'll require a very outdated debug lib instead.Also, requiring
debugactivates the debugger even when no breakpoints are set. Requiringdebug/preludecan avoid it while allowing the use of breakpoints likebinding.breakordebugger.Closes #2266
#skip-changelog