Skip to content

Commit

Permalink
Require debug/prelude instead of debug
Browse files Browse the repository at this point in the history
Requiring `debug` activates the debugger even when no breakpoints are hit.
Although the chance is low, it may slow down the test suite and/or cause
unexpected behavior.

This change requires `debug/prelude` instead of `debug` to avoid the
above issue while still allowing the use of breakpoints.
  • Loading branch information
st0012 committed Mar 20, 2024
1 parent e0df7ba commit 34c1f19
Show file tree
Hide file tree
Showing 6 changed files with 24 additions and 6 deletions.
5 changes: 4 additions & 1 deletion sentry-delayed_job/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end
require "active_record"
require "delayed_job"
require "delayed_job_active_record"
Expand Down
5 changes: 4 additions & 1 deletion sentry-opentelemetry/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
# frozen_string_literal: true

require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end

require 'simplecov'

Expand Down
5 changes: 4 additions & 1 deletion sentry-rails/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end

require "sentry-ruby"
require 'rspec/retry'
Expand Down
5 changes: 4 additions & 1 deletion sentry-resque/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end

require "resque"
require "resque-retry"
Expand Down
5 changes: 4 additions & 1 deletion sentry-ruby/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end
require "timecop"
require "simplecov"
require "rspec/retry"
Expand Down
5 changes: 4 additions & 1 deletion sentry-sidekiq/spec/spec_helper.rb
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
require "bundler/setup"
require "debug" if RUBY_VERSION.to_f >= 2.7 && RUBY_ENGINE == "ruby"
begin
require "debug/prelude"
rescue LoadError
end

# this enables sidekiq's server mode
require "sidekiq/cli"
Expand Down

0 comments on commit 34c1f19

Please sign in to comment.