Don't lock Rails under 7.1 #2229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #2229 +/- ##
=======================================
Coverage 97.61% 97.61%
=======================================
Files 112 112
Lines 4154 4154
=======================================
Hits 4055 4055
Misses 99 99
|
st0012
force-pushed
the
stop-locking-rails-under-7.1
branch
from
e0b8a60
to
9987ff6
Compare
st0012
force-pushed
the
stop-locking-rails-under-7.1
branch
from
3ca4ecb
to
184bbea
Compare
st0012
commented
Mar 30, 2024
| @@ -55,7 +55,6 @@ jobs: | |||
| uses: ruby/setup-ruby@v1 | |||
| with: | |||
| ruby-version: ${{ matrix.ruby_version }} | |||
| bundler-cache: true | |||
There was a problem hiding this comment.
For some reason, the next step always require bundle install for resolving git-based gems. If we were to keep it, then this is not necessary anymore.
sl0thentr0py
approved these changes
Mar 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been over half of a year since Rails 7.1's release. I think all our test suites should include it in the test targets.
#skip-changelog