feat(celery): Set "messaging.system" on span #3024
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-queue-consumer-default-exchange
branch
from
f1671f5
to
67e2531
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
45e8f3b
to
cd65142
Compare
szokeasaurusrex
changed the base branch from
szokeasaurusrex/celery-queue-consumer-default-exchange
to
szokeasaurusrex/celery-messaging-id
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
4 times, most recently
from
55ba199
to
a09959b
Compare
szokeasaurusrex
commented
May 3, 2024
| events = capture_events() | ||
|
|
||
| # Does not need to be a real URL, since we use always eager | ||
| celery.conf.broker_url = f"{system}://example.com" # noqa: E231 |
There was a problem hiding this comment.
Flake8 is giving a false positive E231 on the : in the string when running in CI
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
4 times, most recently
from
92846d8
to
4af0ecb
Compare
szokeasaurusrex
commented
May 7, 2024
| @@ -28,7 +28,7 @@ def init_celery(sentry_init, request): | |||
| def inner(propagate_traces=True, backend="always_eager", **kwargs): | |||
| sentry_init( | |||
| integrations=[CeleryIntegration(propagate_traces=propagate_traces)], | |||
| **kwargs | |||
| **kwargs, | |||
There was a problem hiding this comment.
The formatter is adding this comment, and if I try to commit with the comma remove, CI fails. So I will keep it here
szokeasaurusrex
changed the title
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-id
branch
from
d5a29b9
to
df18b49
Compare
The messaging.system span data attribute should be set to the Celery broker being used, e.g. "amqp" for RabbitMQ, "redis" for Redis, and "sqs" for Amazon SQS. ref #2951
szokeasaurusrex
force-pushed
the
szokeasaurusrex/celery-messaging-system
branch
from
4af0ecb
to
fa16def
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marked as "Work in progress" since I still need to test this PR more thoroughly
Depends on:
ref #2951