Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn when transaction entered without calling start_transaction #3003

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Warn when transaction entered without calling start_transaction #3003

wants to merge 6 commits into from

Commits on Apr 25, 2024

  1. docs(tracing): Delete inaccurate comment 

    `sampled` being set to `False` is not the only reason why the `_span_recorder` might be `None`. Another explanation is that the transaction was not started via `start_transaction`.
    @szokeasaurusrex
    szokeasaurusrex committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    6992f64 View commit details
    Browse the repository at this point in the history

  2. fix(tracing): Correct discarded transaction debug message 

    Transactions that are discarded because `_span_recorder` is `None` can also be discarded because they were not started with `sentry_sdk.start_transaction`. This change updates the debug message accordingly.

Fixes GH-3000
    @szokeasaurusrex
    szokeasaurusrex committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    588f27a View commit details
    Browse the repository at this point in the history

  3. test(tracing): Add tests for discarded transaction debug messages

    @szokeasaurusrex
    szokeasaurusrex committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    d0fc544 View commit details
    Browse the repository at this point in the history

  4. feat(tracing): Warn when transaction entered without calling `start_t… 

    …ransaction`

Users who enter a transaction without calling `start_transaction` likely intended to start the transaction, since without a call to `start_transaction`, their transaction will not get sent to Sentry. This warning message clarifies this behavior, and could help avoid the confusion that led to issue #2990.
    @szokeasaurusrex
    szokeasaurusrex committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    e107d46 View commit details
    Browse the repository at this point in the history

  5. test(tracing): Add test for transaction not started warning

    @szokeasaurusrex
    szokeasaurusrex committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    881304d View commit details
    Browse the repository at this point in the history

  6. ref(tracing): Rename _possibly_started function 

    The previous name, `_possibly_stated`, contains a typo, which this change fixes.

Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
    @szokeasaurusrex @antonpirker
    szokeasaurusrex and antonpirker committed Apr 25, 2024
    Configuration menu
    Copy the full SHA
    84ab96a View commit details
    Browse the repository at this point in the history