Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(metrics): Add value, unit to before_emit_metric #2958

Merged
merged 5 commits into from
Apr 10, 2024

Conversation

sentrivana
Copy link
Contributor

Closes #2956


General Notes

Thank you for contributing to sentry-python!

Please add tests to validate your changes, and lint your code using tox -e linters.

Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.

For maintainers

Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.

Before running sensitive test suites, please carefully check the PR. Then, apply the Trigger: tests using secrets label. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.

@sentrivana sentrivana marked this pull request as ready for review April 10, 2024 09:16
@sentrivana sentrivana enabled auto-merge (squash) April 10, 2024 11:04
@sentrivana sentrivana merged commit a1ab339 into master Apr 10, 2024
124 checks passed
@sentrivana sentrivana deleted the ivana/before-emit-metric-more-args branch April 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metrics] Expose more parameters to before_emit_metric
2 participants