Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(profiling): Add thread data to spans #2843

Merged
merged 21 commits into from Mar 20, 2024

Conversation

Zylphrex
Copy link
Member

@Zylphrex Zylphrex commented Mar 18, 2024

As per getsentry/rfcs#75 getsentry/rfc#75, this adds the thread data to the spans. This will be needed for the continuous profiling mode in #2830.

As per getsentry/rfc#75, this adds the thread data to the spans. This will be
needed for the continuous profiling mode in #2830.
@Zylphrex Zylphrex force-pushed the txiao/feat/add-thread-data-to-spans branch from 2344d79 to 95331f5 Compare March 18, 2024 21:41
@Zylphrex Zylphrex marked this pull request as ready for review March 19, 2024 16:13
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok.

This somewhat weakens our tests, but after talking with the other Python people and also confirmed with Ingest that if there is an onknown value in span data it is just stored anyhow. I think this is fine.

@Zylphrex
Copy link
Member Author

Looks ok.

This somewhat weakens our tests, but after talking with the other Python people and also confirmed with Ingest that if there is an onknown value in span data it is just stored anyhow. I think this is fine.

👍 I'm not sure there's a stronger test we can add here as the thread ids are unstable. The only alternative I can think of is to mock it in each place which seems worse because now every test is concerned about mocking the thread id data appropriately to pass. Which is why I opted for each test to just assert that the relevant properties are added to the span data.

@Zylphrex Zylphrex enabled auto-merge (squash) March 20, 2024 15:20
@Zylphrex Zylphrex disabled auto-merge March 20, 2024 16:24
@Zylphrex Zylphrex merged commit 48d7767 into master Mar 20, 2024
124 checks passed
@Zylphrex Zylphrex deleted the txiao/feat/add-thread-data-to-spans branch March 20, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants