GrapheneIntegration: Track operation name for tracing #2704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithhackbarth
changed the title
|
Hi @keithhackbarth, i would love to see this change! |
czyber
added a commit
to czyber/sentry-python
that referenced
this pull request
Feb 24, 2024
… query getsentry#2704 This commit adds a missing test for the graphene integration, so that we can be sure that a transaction with the corresponding query name is captured.
… query getsentry#2704 This commit adds a missing test for the graphene integration, so that we can be sure that a transaction with the corresponding query name is captured. --amend
|
Hey @keithhackbarth, i added a test and made a PR on your fork 😄 |
Feature/add graphene tests
czyber
added a commit
to czyber/sentry-python
that referenced
this pull request
Mar 8, 2024
… query getsentry#2704 This commit adds a missing test for the graphene integration, so that we can be sure that a transaction with the corresponding query name is captured. --amend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is helpful to have the operation's name if trying to track the individual performance of GraphQL transactions using Sentry. This PR implements the approach suggested in this article, as part of the GrapheneIntegration()
Note: I looked and wasn't initially sure how to write a good test for this and also wasn't sure if this PR is even a good idea in the first place. So leaving a light version here for feedback.