Remove compatibility utils for old Python #2645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sentrivana
commented
Jan 16, 2024
sentrivana
commented
Jan 16, 2024
sentrivana
commented
Jan 16, 2024
sentrivana
commented
Jan 16, 2024
sentrivana
commented
Jan 16, 2024
Co-authored-by: Daniel Szoke <szokeasaurusrex@users.noreply.github.com>
szokeasaurusrex
approved these changes
Jan 16, 2024
sentry_sdk/tracing.py
Outdated
| @@ -14,7 +14,7 @@ | |||
| from typing import Dict | |||
| from typing import Iterator | |||
| from typing import List | |||
| from typing import Mapping | |||
| from collections.abc import Mapping | |||
There was a problem hiding this comment.
Small nitpick (feel free to leave unchanged): Now that you changed this line to import from collections.abc instead of from typing, it is a bit weird that it is surrounded by typing imports. Could you reorder this import to be above all the typing imports?
On a related note, it would be nice if we could use some kind of automatic Python formatting tool to automatically enforce alphabetical ordering for imports. Something like this exists in Rust, and I find that it helps keep code more organized.
There was a problem hiding this comment.
There are multiple tools for this in Python, too, e.g. isort. Would be very happy to have this automated at some point. Will change the order here manually.
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to remove Python 2.7 and 3.5 compatibility utils from
_compat.pyand replace them with their Python 3.6+ equivalents throughout the codebase.Note: This PR removes some import handling for imports that are different between py2 and py3, but not all -- this will be done in a separate PR.
General Notes
Thank you for contributing to
sentry-python!Please add tests to validate your changes, and lint your code using
tox -e linters.Running the test suite on your PR might require maintainer approval. Some tests (AWS Lambda) additionally require a maintainer to add a special label to run and will fail if the label is not present.
For maintainers
Sensitive test suites require maintainer review to ensure that tests do not compromise our secrets. This review must be repeated after any code revisions.
Before running sensitive test suites, please carefully check the PR. Then, apply the
Trigger: tests using secretslabel. The label will be removed after any code changes to enforce our policy requiring maintainers to review all code revisions before running sensitive tests.