New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(integrations): Add integerations for grpc.aio #2055
Conversation
Capture unhandled exceptions in the async grpc server interceptor.
This pull request has gone three weeks without activity. In another week, I will close it. But! If you comment or otherwise update it, I will reset the clock, and if you label it "A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀 |
Hi, |
@alisoam FYI: As this PR was already 5 months old, I didn't expect somebody to continue working on it so soon. Therefore, I pulled your branch, added the If you can use anything from there feel free to do so and cherry-pick the commits, of course I don't want to overrule your efforts here 😉 I pushed the changes here. Will then submit the integration in an extra PR later 👍 😄 |
Hey @alisoam and @fdellekart ! Yea, sorry for it taking so long. But I will now have time to look at it. Thanks to both of you! |
I merged the current branch into mine and squashed/reworded the commits a bit to adhere to the formats described in the contribution guidelines. Therefore, we could actually just continue this there if that's ok for everybody. I opened #2369 for this purpose 👍 |
Hi @fdellekart, |
Perfect, thx 👍 I am currently on vacation until mid next week but will have a look on your comments afterwards 🙂 |
Ok, very cool @alisoam and @fdellekart ! |
Add server interceptor for asyncio grpc servers.