Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to noop when there is no DSN #1852

Merged
merged 8 commits into from Jan 20, 2023
Merged

Make sure to noop when there is no DSN #1852

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
81c87cb
Make sure to noop when there is no DSN
antonpirker Jan 19, 2023
beea55c
Merge branch 'master' into antonpirker/otel-noop-on-missing-dsn
antonpirker Jan 19, 2023
8f22349
Better condition
antonpirker Jan 19, 2023
e13c256
Merge branch 'antonpirker/otel-noop-on-missing-dsn' of github.com:get…
antonpirker Jan 19, 2023
0ad170b
Merge branch 'master' into antonpirker/otel-noop-on-missing-dsn
antonpirker Jan 19, 2023
99712d5
Check for invalid dsn.
antonpirker Jan 20, 2023
bfa2f50
Merge branch 'antonpirker/otel-noop-on-missing-dsn' of github.com:get…
antonpirker Jan 20, 2023
21c66a2
Fixed typing
antonpirker Jan 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 8 additions & 0 deletions sentry_sdk/integrations/opentelemetry/span_processor.py
View file
Open in desktop
Expand Up @@ -98,6 +98,14 @@ def on_start(self, otel_span, parent_context=None):
if not hub:
return

if not hub.client or (hub.client and not hub.client.dsn):
antonpirker marked this conversation as resolved.
Show resolved Hide resolved
return

try:
_ = Dsn(hub.client.dsn or "")
except Exception:
return

if hub.client and hub.client.options["instrumenter"] != INSTRUMENTER.OTEL:
return

Expand Down