Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(otel): NoOpSpan updates scope #1834

Merged
merged 2 commits into from Jan 17, 2023
Merged

fix(otel): NoOpSpan updates scope #1834

merged 2 commits into from Jan 17, 2023

Commits on Jan 13, 2023

  1. fix(otel): NoOpSpan updates scope 

    When using otel as the instrumentor, the NoOpSpan needs to update the scope when
it's used as a context manager. If it does not, then this differs from the usual
behaviour of a span and the end user may start seeing an unexpected `None` on
the scope.
    @Zylphrex
    Zylphrex committed Jan 13, 2023
    Copy the full SHA
    ab3b054 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2023

  1. run black

    @Zylphrex
    Zylphrex committed Jan 16, 2023
    Copy the full SHA
    e9d5bdb View commit details
    Browse the repository at this point in the history