Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): Fix Celery TypeError with no-argument apply_async #2575

Merged
merged 3 commits into from Dec 7, 2023

Conversation

szokeasaurusrex
Copy link
Member

Fix a bug where calling task.apply_async(None, {}) (where task is some Celery task) raises an unhandled TypeError. Also, add a test that validates that the call succeeds.

Fixes GH-2554

@szokeasaurusrex szokeasaurusrex marked this pull request as ready for review December 7, 2023 16:19
@szokeasaurusrex szokeasaurusrex requested review from antonpirker and sentrivana and removed request for sentrivana December 7, 2023 16:19
@szokeasaurusrex szokeasaurusrex enabled auto-merge (squash) December 7, 2023 16:19
Copy link
Contributor

@sentrivana sentrivana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

auto-merge was automatically disabled December 7, 2023 16:26

Pull Request is not mergeable

@sentrivana sentrivana enabled auto-merge (squash) December 7, 2023 16:33
@sentrivana sentrivana merged commit b656f79 into master Dec 7, 2023
469 checks passed
@sentrivana sentrivana deleted the szokeasaurusrex/fix-celery-typeerror branch December 7, 2023 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TypeError raised in the celery integration when calling a task.apply_async without arguments
2 participants