Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Send to Spotlight sidecar #2524

Merged
merged 8 commits into from Nov 23, 2023
Merged

feat: Send to Spotlight sidecar #2524

merged 8 commits into from Nov 23, 2023

Conversation

HazAT
Copy link
Member

@HazAT HazAT commented Nov 22, 2023 •
edited

Add Spotlight option to SDK:

sentry_sdk.init(
        spotlight=True,
    )
    
# OR

sentry_sdk.init(
        spotlight='https://mycustom.ur',
    )

@HazAT HazAT marked this pull request as ready for review November 23, 2023 13:41
antonpirker
antonpirker approved these changes Nov 23, 2023
View reviewed changes
Copy link
Member

@antonpirker antonpirker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just some minor nitpicks

sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
sentry_sdk/client.py Outdated Show resolved Hide resolved
sentry_sdk/spotlight.py Outdated Show resolved Hide resolved
HazAT and others added 2 commits November 23, 2023 16:28
@HazAT @antonpirker
Apply suggestions from code review
c36c13a 
Co-authored-by: Anton Pirker <anton.pirker@sentry.io>
@HazAT
CR
0516ff0
@antonpirker antonpirker enabled auto-merge (squash) November 23, 2023 15:37
@antonpirker antonpirker merged commit 088431e into master Nov 23, 2023
313 of 314 checks passed
@antonpirker antonpirker deleted the feat/spotlight branch November 23, 2023 15:42
@HazAT HazAT mentioned this pull request Nov 23, 2023
Merged
@bruno-garcia bruno-garcia mentioned this pull request Dec 7, 2023
Closed
This was referenced Dec 13, 2023
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antonpirker antonpirker antonpirker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@HazAT @antonpirker @sl0thentr0py