Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure to noop when there is no DSN #1852

Merged
merged 8 commits into from Jan 20, 2023
Merged

Make sure to noop when there is no DSN #1852

merged 8 commits into from Jan 20, 2023

Conversation

antonpirker
Copy link
Member

This will fix #1845

@antonpirker antonpirker marked this pull request as ready for review January 19, 2023 13:13
adinauer
adinauer approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@adinauer adinauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one question

sentry_sdk/integrations/opentelemetry/span_processor.py Show resolved Hide resolved
@antonpirker antonpirker merged commit 032ea57 into master Jan 20, 2023
@antonpirker antonpirker deleted the antonpirker/otel-noop-on-missing-dsn branch January 20, 2023 09:06
@antonpirker antonpirker self-assigned this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adinauer adinauer adinauer approved these changes

Assignees

@antonpirker antonpirker

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Empty DSN crashes Otel integration
2 participants
@antonpirker @adinauer