fix up tests

getsentry · Jan 6, 2023 · a9ffd5b · a9ffd5b
1 parent d8add1b
commit a9ffd5b
Showing 1 changed file with 7 additions and 12 deletions.
diff --git a/tests/test_profiler.py b/tests/test_profiler.py
@@ -26,6 +26,8 @@
     sys.version_info < (3, 3), reason="Profiling is only supported in Python >= 3.3"
 )
 
+requires_gevent = pytest.mark.skipif(gevent is None, reason="gevent not enabled")
+
 
 def process_test_sample(sample):
     return [(tid, (stack, stack)) for tid, stack in sample]
@@ -34,10 +36,10 @@ def process_test_sample(sample):
 @pytest.mark.parametrize(
     "mode",
     [
-        pytest.param("magic"),
+        pytest.param("foo"),
         pytest.param(
             "gevent",
-            marks=pytest.mark.skipif(gevent is None, reason="gevent not installed"),
+            marks=pytest.mark.skipif(gevent is not None, reason="gevent not enabled"),
         ),
     ],
 )
@@ -51,10 +53,7 @@ def test_profiler_invalid_mode(mode, teardown_profiling):
     [
         pytest.param("thread"),
         pytest.param("sleep"),
-        pytest.param(
-            "gevent",
-            marks=pytest.mark.skipif(gevent is None, reason="gevent not installed"),
-        ),
+        pytest.param("gevent", marks=requires_gevent),
     ],
 )
 def test_profiler_valid_mode(mode, teardown_profiling):
@@ -284,7 +283,7 @@ def get_scheduler_threads(scheduler):
         pytest.param(
             GeventScheduler,
             marks=[
-                pytest.mark.skipif(gevent is None, reason="gevent not installed"),
+                requires_gevent,
                 pytest.mark.skip(
                     reason="cannot find this thread via threading.enuerate()"
                 ),
@@ -611,11 +610,7 @@ def test_thread_scheduler_single_background_thread(scheduler_class):
     ("scheduler_class",),
     [
         pytest.param(ThreadScheduler, id="thread scheduler"),
-        pytest.param(
-            GeventScheduler,
-            marks=pytest.mark.skipif(gevent is None, reason="gevent not installed"),
-            id="gevent scheduler",
-        ),
+        pytest.param(GeventScheduler, marks=requires_gevent, id="gevent scheduler"),
     ],
 )
 def test_profile_processing(