Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(remix): Skip flaky firefox integration tests #8506

Merged
merged 1 commit into from
Jul 11, 2023
Merged

test(remix): Skip flaky firefox integration tests #8506

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
37 changes: 34 additions & 3 deletions packages/remix/test/integration/test/client/meta-tags.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,13 @@ import { test, expect } from '@playwright/test';
import { getFirstSentryEnvelopeRequest } from './utils/helpers';
import { Event } from '@sentry/types';

test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page }) => {
test('should inject `sentry-trace` and `baggage` meta tags inside the root page.', async ({ page, browserName }) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

await page.goto('/');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -16,7 +22,16 @@ test('should inject `sentry-trace` and `baggage` meta tags inside the root page.
expect(sentryBaggageContent).toEqual(expect.any(String));
});

test('should inject `sentry-trace` and `baggage` meta tags inside a parameterized route.', async ({ page }) => {
test('should inject `sentry-trace` and `baggage` meta tags inside a parameterized route.', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

await page.goto('/loader-json-response/0');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -30,7 +45,16 @@ test('should inject `sentry-trace` and `baggage` meta tags inside a parameterize
expect(sentryBaggageContent).toEqual(expect.any(String));
});

test('should send transactions with corresponding `sentry-trace` and `baggage` inside root page', async ({ page }) => {
test('should send transactions with corresponding `sentry-trace` and `baggage` inside root page', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

const envelope = await getFirstSentryEnvelopeRequest<Event>(page, '/');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand All @@ -47,7 +71,14 @@ test('should send transactions with corresponding `sentry-trace` and `baggage` i

test('should send transactions with corresponding `sentry-trace` and `baggage` inside a parameterized route', async ({
page,
browserName,
}) => {
// This test is flaky on firefox
// https://github.com/getsentry/sentry-javascript/issues/8398
if (browserName === 'firefox') {
test.skip();
}

const envelope = await getFirstSentryEnvelopeRequest<Event>(page, '/loader-json-response/0');

const sentryTraceTag = await page.$('meta[name="sentry-trace"]');
Expand Down