Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(replay): Fix buffered replays creating replay w/o error occuring #8168

Merged
merged 4 commits into from
May 23, 2023
Merged

fix(replay): Fix buffered replays creating replay w/o error occuring #8168

merged 4 commits into from
May 23, 2023

Commits on May 19, 2023

  1. fix(replay): Fix buffered replays creating replay w/o error occuring 

    Introduced in #7741. This happens when session replay rate is > 0 and the session is unsampled, it calls `stop()` which ends up flushing without checking the recording mode (session vs buffer).

Closes #8054
    @billyvg
    billyvg committed May 19, 2023
    Configuration menu
    Copy the full SHA
    ef44abc View commit details
    Browse the repository at this point in the history

  2. adjust comments

    @billyvg
    billyvg committed May 19, 2023
    Configuration menu
    Copy the full SHA
    a5b02ea View commit details
    Browse the repository at this point in the history

  3. fix test

    @billyvg
    billyvg committed May 19, 2023
    Configuration menu
    Copy the full SHA
    8ecceda View commit details
    Browse the repository at this point in the history

Commits on May 23, 2023

  1. Merge branch 'develop' into fix-replay-buffer-records-without-error

    @billyvg
    billyvg committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bfa8ae2 View commit details
    Browse the repository at this point in the history