Add semicolons

[jensenbox]

To allow certain minfiers to work properly.

[benvinegar]

This isn't going to work. These are dist files generated from source every release, aka this would just be undone when we release a new version.

We'll need to either get a patch accepted upstream in json-stringify-safe (unlikely), or we need to modify the build process to semicolon-ify our dist files going forward.

[jensenbox]

I figured as much. the crux of the issue really is when: var thisPos = stack.indexOf(this) ~thisPos ? stack.splice(thisPos + 1) : stack.push(this); turns into: var thisPos = stack.indexO*f(this)~th*isPos ? stack.splice(thisPos + 1) : stack.push(this); I suspect that there could be a corner case regarding the tilde character in the compressor I am using. It is mashing them together. Thanks for listening :)

…

On Thu, Dec 15, 2016 at 4:42 PM, Ben Vinegar ***@***.***> wrote: This isn't going to work. These are dist files generated from source. We'll need to either get a patch accepted upstream in json-stringify-safe (unlikely), or we need to modify the build process to semicolon-ify our dist files going forward. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#804 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AALjUY-w577qigiQ4wk6duZvAh91ED_Jks5rId6FgaJpZM4LOufs> .

-- *Christian Jensen* 2311 Watkiss Way Unit #1 Victoria, BC V9B 6J6 +1 (778) 996-4283 christian@jensenbox.com

[mreq]

This problem still exist when using raven in Rails 5 with the uglifier gem. If you run into this, use the minified version in the pipeline.

[kamilogorek]

@mreq it will be fixed with the next release, as it's already fixed in the sources https://github.com/getsentry/raven-js/blob/master/vendor/json-stringify-safe/stringify.js#L14-L15