Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update source map docs for 2016 #613

Merged
merged 4 commits into from
Jun 20, 2016
Merged

Update source map docs for 2016 #613

merged 4 commits into from
Jun 20, 2016

Conversation

benvinegar
Copy link
Contributor

@benvinegar benvinegar commented Jun 19, 2016 •
edited

Fixes #604

  • Remove browser compatibility comments – supported by all major current browsers now
  • Not just strictly "minification" anymore, add comments re: language transpilation
  • Link to Sentry's source map intro blog post
  • Add instructions for Webpack

cc @mattrobenolt

@mattrobenolt
Copy link
Contributor

🍪

@benvinegar
Copy link
Contributor Author

Mmm, I should add something about making them available via HTTP.

@benvinegar
Copy link
Contributor Author

benvinegar commented Jun 20, 2016 •
edited

@mattrobenolt – mind taking another look? Made a few changes.

  • Added a section on hosting source maps
  • Moved the VPN section as an admonition of the new "hosting source maps" section
  • Moved "Validate Source Maps" to the Troubleshooting section

mattrobenolt
mattrobenolt reviewed Jun 20, 2016
View reviewed changes
docs/sourcemaps.rst

We maintain an online validation tool that can be used to test your source
(and sourcemaps) against: `sourcemaps.io <http://sourcemaps.io>`_.
1) Served publicly over HTTP alongside your source files.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd flip the order of these since we recommend uploading over us fetching them.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather put a "recommended" tag by #2. I think #1 logically is the first thing to explain to someone, and it's far easier to set up.

@benvinegar benvinegar merged commit d46d8f6 into master Jun 20, 2016
@benvinegar benvinegar deleted the fix-trailing-sentence branch February 28, 2017 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@benvinegar @mattrobenolt