fix(node): Ensure incoming traces are propagated without HttpInstrumentation #15732
+42
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
chargome
approved these changes
Mar 19, 2025
| ...options, | ||
| // If spans are not instrumented, it means the HttpInstrumentation has not been added | ||
| // In that case, we want to handle incoming trace extraction ourselves | ||
| extractIncomingTraceFromHeader: !instrumentSpans, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #15730
Noticed that this is not really happening otherwise, so if we are not adding the
HttpInstrumentationwe now make sure to extract incoming traces ourselves! This will unlock us not adding that instrumentation when tracing is disabled.Also includes #15731 as a side effect.