Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(v8/node): Ensure NODE_OPTIONS is not passed to worker threads #14825

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

timfish
Copy link
Collaborator

@timfish timfish commented Dec 22, 2024

Backport of #14824

Copy link
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 23.29 KB - -
@sentry/browser - with treeshaking flags 21.96 KB - -
@sentry/browser (incl. Tracing) 35.81 KB - -
@sentry/browser (incl. Tracing, Replay) 73.06 KB - -
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 63.45 KB - -
@sentry/browser (incl. Tracing, Replay with Canvas) 77.37 KB - -
@sentry/browser (incl. Tracing, Replay, Feedback) 89.85 KB - -
@sentry/browser (incl. Feedback) 40.04 KB - -
@sentry/browser (incl. sendFeedback) 27.89 KB - -
@sentry/browser (incl. FeedbackAsync) 32.68 KB - -
@sentry/react 25.96 KB - -
@sentry/react (incl. Tracing) 38.64 KB - -
@sentry/vue 27.52 KB - -
@sentry/vue (incl. Tracing) 37.67 KB - -
@sentry/svelte 23.45 KB - -
CDN Bundle 24.47 KB - -
CDN Bundle (incl. Tracing) 37.51 KB - -
CDN Bundle (incl. Tracing, Replay) 72.71 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) 78.1 KB - -
CDN Bundle - uncompressed 71.85 KB - -
CDN Bundle (incl. Tracing) - uncompressed 111.23 KB - -
CDN Bundle (incl. Tracing, Replay) - uncompressed 225.3 KB - -
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 238.52 KB - -
@sentry/nextjs (client) 38.9 KB - -
@sentry/sveltekit (client) 36.32 KB - -
@sentry/node 162.72 KB +0.02% +24 B 🔺
@sentry/node - without tracing 98.89 KB +0.02% +16 B 🔺
@sentry/aws-serverless 126.54 KB +0.02% +14 B 🔺

View base workflow run

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

heads-up: Just changing the commit message because we settled on fix(v8/*) prefixes instead of the [v8] for consistency.

@Lms24 Lms24 changed the title fix(node): Ensure NODE_OPTIONS is not passed to worker threads [v8] fix(v8/node): Ensure NODE_OPTIONS is not passed to worker threads Dec 23, 2024
@Lms24 Lms24 merged commit e7b3530 into v8 Dec 23, 2024
114 checks passed
@Lms24 Lms24 deleted the timfish/fix/worker-threads-backport branch December 23, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants