feat(flags): Adds LaunchDarkly and OpenFeature integrations #14207
+857
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…try-javascript into aliu/launch-darkly
…try-javascript into aliu/launch-darkly
…ag field and methods
aliu39
commented
Nov 7, 2024
aliu39
commented
Nov 8, 2024
…ration feat(flags): Add OpenFeature integration
…tion-abstraction ref(flags): Refactor LaunchDarkly integration to reusable functions
cmanallen
changed the title
billyvg
reviewed
Dec 4, 2024
packages/browser/src/index.ts
Outdated
| @@ -77,3 +68,6 @@ export type { Span } from '@sentry/core'; | |||
| export { makeBrowserOfflineTransport } from './transports/offline'; | |||
| export { browserProfilingIntegration } from './profiling/integration'; | |||
| export { spotlightBrowserIntegration } from './integrations/spotlight'; | |||
| export { copyFlagsFromScopeToEvent, insertFlagToScope } from './utils/featureFlags'; | |||
There was a problem hiding this comment.
Let's remove these exports - they shouldn't be public
billyvg
approved these changes
Dec 4, 2024
|
Just for reference for the next time @aliu39 , please make sure to use squash merge :) No big deal, and we know it is not ideal that we cannot enforce this right now in this repo, so it's a bit of a manual thing sadly 😬 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds browser integrations for tracking feature flag evaluations through the LaunchDarkly JS SDK and OpenFeature Web SDK
Notion doc summarizing our goal, constraints, and potential approaches: https://www.notion.so/sentry/Feature-Flags-JavaScript-SDK-1358b10e4b5d805288abe1a4fede75ed?pvs=4. This PR implements approach 1.
Also see https://develop.sentry.dev/sdk/expected-features/#feature-flags
Ref
Decisions:
LDInspectionFlagUsedHandler) separately fromSentry.init(). Unlike python, it's not possible to do this when instantiating the integration.Both integrations are live and verified to work, in
DOCS:
launchdarkly
openfeature
feature flags product index