fix(react): Support wildcard routes on React Router 6 #14205
Merged
+213
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onurtemizkan
force-pushed
the
onur/react-router-6-wildcards
branch
2 times, most recently
from
00c3500 to
7989575
Compare
size-limit report 📦
|
onurtemizkan
force-pushed
the
onur/react-router-6-wildcards
branch
2 times, most recently
from
e079611 to
cbdebd8
Compare
onurtemizkan
force-pushed
the
onur/react-router-6-wildcards
branch
from
cbdebd8 to
a5aabf9
Compare
AbhiPrasad
approved these changes
Nov 7, 2024
Comment on lines
+148
to
+155
| const formattedPath = | ||
| // If the path ends with a slash, remove it | ||
| reconstructedPath[reconstructedPath.length - 1] === '/' | ||
| ? reconstructedPath.slice(0, -1) | ||
| : // If the path ends with a wildcard, remove it | ||
| reconstructedPath.slice(-2) === '/*' | ||
| ? reconstructedPath.slice(0, -1) | ||
| : reconstructedPath; |
There was a problem hiding this comment.
I wonder if a regex replace is less expensive here. Would be interesting to benchmark.
There was a problem hiding this comment.
Just tried now, looks like it's slower in this case https://jsperf.app/gemolu
This was referenced Nov 11, 2024
Closed
AbhiPrasad
added a commit
that referenced
this pull request
Nov 11, 2024
Add @grahamhency to changelog for work in #14205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on @grahamhency's work at #14076.
Sets correct transaction names when wildcards are used in React Router 6 routes.
This does not fix the usage of the descendant routes (#5997), which we should try to address separately.