fix(sveltekit): update wrapServerRouteWithSentry to respect ParamMatchers #13390
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @gurpreetatwal thanks for opening this PR! I'm sorry for the late review. Looks fine to me. Since we're only extending the previous type I this doesn't classify as a breaking change so we can merge it in. (heads-up: Just assigning myself to track internally that I'm reviewing it) |
Lms24
approved these changes
Sep 18, 2024
|
I see this PR is still in draft - did you want to add something to still? |
|
Hi @Lms24! Apologies for the delayed response on my end, we're good to merge! I had it in draft status because I was trying to get the test suite to run on my computer but wasn't able to and hadn't yet had the time to figure out if it was a code issue or a just dev set up issues. |
…hers SvelteKit narrows the type of event.params based on ParamMatchers that are defined in the path, by making the function generic we can respect the narrowed type
|
Thanks for getting back to me! Will let CI run again on the changes and then merge it. |
This was referenced Nov 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SvelteKit narrows the type of event.params based on ParamMatchers that are defined in the path, by making the function generic we can respect the narrowed type
Before submitting a pull request, please take a look at our
Contributing guidelines and verify:
yarn lint) & (yarn test).Follow up to #13247