-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(metrics): Map statsd
to metric_bucket
#11505
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,7 @@ | ||
// This type is used in various places like Client Reports and Rate Limit Categories | ||
// See: | ||
// - https://develop.sentry.dev/sdk/rate-limiting/#definitions | ||
// - https://github.com/getsentry/relay/blob/c3b339e151c1e548ede489a01c65db82472c8751/relay-common/src/constants.rs#L139-L152 | ||
// - https://github.com/getsentry/relay/blob/ec791fed9c2260688f25ea6a6d53ab913927e9a5/relay-base-schema/src/data_category.rs#L91 | ||
// - https://develop.sentry.dev/sdk/client-reports/#envelope-item-payload under `discarded_events` | ||
export type DataCategory = | ||
// Reserved and only used in edgecases, unlikely to be ever actually used | ||
|
@@ -26,8 +26,8 @@ export type DataCategory = | |
| 'monitor' | ||
// Feedback type event (v2) | ||
| 'feedback' | ||
// Statsd type event for metrics | ||
| 'statsd' | ||
// Metrics sent via the statsd or metrics envelope items. `namespace` defines which namespace(s) will be affected | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. what does There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. That relates to the rate limiting: https://develop.sentry.dev/sdk/rate-limiting/ There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. yeah I was just confused about the comment in this context as "namespace" is not mentioned in this entry - IMHO OK to remove this or move this comment closer to where There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yeah, I moved the comment to where |
||
| 'metric_bucket' | ||
// Span | ||
| 'span' | ||
// Unknown data category | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
l: Maybe we can just reference
master
branch here? 🤔 but not sure, feel free to disregard.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't add it from master, as the file was moved already (why I changed the link). If the link would have been from master, it would've been harder to actually find the correct file as you would just get a 404. But as I could still see the old implementation, it was easier for me to find the new place of the code :)