Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(v7): Deprecate addRequestDataToTransaction #11368

Merged
merged 1 commit into from
Apr 2, 2024
Merged

ref(v7): Deprecate addRequestDataToTransaction #11368

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/node/src/handlers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,7 @@ export function tracingHandler(): (
// Push `transaction.finish` to the next event loop so open spans have a chance to finish before the transaction
// closes
setImmediate(() => {
// eslint-disable-next-line deprecation/deprecation
addRequestDataToTransaction(transaction, req);
setHttpStatus(transaction, res.statusCode);
transaction.end();
Expand Down
4 changes: 3 additions & 1 deletion packages/utils/src/requestdata.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ export type TransactionNamingScheme = 'path' | 'methodPath' | 'handler';

/**
* Sets parameterized route as transaction name e.g.: `GET /users/:id`
* Also adds more context data on the transaction from the request
* Also adds more context data on the transaction from the request.
*
* @deprecated This utility will be removed in v8.
*/
export function addRequestDataToTransaction(
transaction: Transaction | undefined,
Expand Down