Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): [v7] Skip capturing Hapi Boom error responses #11324

Merged
merged 2 commits into from
Mar 28, 2024

Commits on Mar 27, 2024

  1. fix(node): Skip capturing Hapi Boom error responses. (#11151)

    Resolves: #11069
    
    After checking the behaviour, it seems to me that we don't need to
    capture any Boom responses, as the errors that may cause a `5xx`
    response are already captured by the core logic. To add an option to
    control this behaviour, we need to update the usage of
    `hapiErrorPlugin`, converting it to a function signature, which IMO may
    not worth doing, as I'm not sure if users in general would need to use
    it.
    
    This also adds `expectError()` to the `node-integration-tests` runner to
    allow `5xx` responses to be tested.
    onurtemizkan authored and AbhiPrasad committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    4dad740 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2024

  1. Configuration menu
    Copy the full SHA
    5e2ffa3 View commit details
    Browse the repository at this point in the history