Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(v7/core): Backport ResizeObserver and googletag default filters #11210

Merged
merged 3 commits into from Mar 20, 2024
Merged

feat(v7/core): Backport ResizeObserver and googletag default filters #11210

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
14d6b40
feat(core): Add Googletag error to InboundFilters default ignore list
Lms24 Mar 20, 2024
188bbe4
Trigger Build
Lms24 Mar 20, 2024
042b3b2
increase size limit :(
Lms24 Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/core/src/integrations/inboundfilters.ts
View file
Open in desktop
Expand Up @@ -6,7 +6,12 @@ import { convertIntegrationFnToClass, defineIntegration } from '../integration';

// "Script error." is hard coded into browsers for errors that it can't read.
// this is the result of a script being pulled in from an external domain and CORS.
const DEFAULT_IGNORE_ERRORS = [/^Script error\.?$/, /^Javascript error: Script error\.? on line 0$/];
const DEFAULT_IGNORE_ERRORS = [
/^Script error\.?$/,
/^Javascript error: Script error\.? on line 0$/,
/^ResizeObserver loop completed with undelivered notifications.$/,
/^Cannot redefine property: googletag$/,
];

const DEFAULT_IGNORE_TRANSACTIONS = [
/^.*\/healthcheck$/,
Expand Down
34 changes: 33 additions & 1 deletion packages/core/test/lib/integrations/inboundfilters.test.ts
View file
Open in desktop
Expand Up @@ -188,6 +188,28 @@ const SCRIPT_ERROR_EVENT: Event = {
},
};

const RESIZEOBSERVER_EVENT: Event = {
exception: {
values: [
{
type: 'Error',
value: 'ResizeObserver loop completed with undelivered notifications.',
},
],
},
};

const GOOGLETAG_EVENT: Event = {
exception: {
values: [
{
type: 'TypeError',
value: 'Cannot redefine property: googletag',
},
],
},
};

const MALFORMED_EVENT: Event = {
exception: {
values: [
Expand Down Expand Up @@ -304,11 +326,21 @@ describe('InboundFilters', () => {
expect(eventProcessor(EXCEPTION_EVENT, {})).toBe(null);
});

it('uses default filters', () => {
it('uses default filters (script error)', () => {
const eventProcessor = createInboundFiltersEventProcessor();
expect(eventProcessor(SCRIPT_ERROR_EVENT, {})).toBe(null);
});

it('uses default filters (ResizeObserver)', () => {
const eventProcessor = createInboundFiltersEventProcessor();
expect(eventProcessor(RESIZEOBSERVER_EVENT, {})).toBe(null);
});

it('uses default filters (googletag)', () => {
const eventProcessor = createInboundFiltersEventProcessor();
expect(eventProcessor(GOOGLETAG_EVENT, {})).toBe(null);
});

it('filters on last exception when multiple present', () => {
const eventProcessor = createInboundFiltersEventProcessor({
ignoreErrors: ['incorrect type given for parameter `chewToy`'],
Expand Down