Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(metrics): use correct statsd data category #11187

Merged
merged 1 commit into from
Mar 19, 2024
Merged

fix(metrics): use correct statsd data category #11187

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/types/src/datacategory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,9 @@ export type DataCategory =
| 'monitor'
// Feedback type event (v2)
| 'feedback'
// Unknown data category
| 'unknown'
// Statsd type event for metrics
| 'statsd'
// Span
| 'span';
| 'span'
// Unknown data category
| 'unknown';
3 changes: 1 addition & 2 deletions packages/utils/src/envelope.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,8 +210,7 @@ const ITEM_TYPE_TO_DATA_CATEGORY_MAP: Record<EnvelopeItemType, DataCategory> = {
check_in: 'monitor',
feedback: 'feedback',
span: 'span',
// TODO: This is a temporary workaround until we have a proper data category for metrics
statsd: 'unknown',
statsd: 'statsd',
};

/**
Expand Down