-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(replay): Add errorHandler
for replayCanvas integration
#10796
Merged
billyvg
merged 3 commits into
develop
from
fix-replay-canvas-manager-needs-error-handler
Feb 29, 2024
Merged
fix(replay): Add errorHandler
for replayCanvas integration
#10796
billyvg
merged 3 commits into
develop
from
fix-replay-canvas-manager-needs-error-handler
Feb 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`errorHandler` for `CanvasManager` was added in the latest rrweb, but was not configured in our integration.
size-limit report 📦
|
AbhiPrasad
approved these changes
Feb 29, 2024
Closed
AbhiPrasad
pushed a commit
that referenced
this pull request
Feb 29, 2024
`errorHandler` for `CanvasManager` was added in the latest rrweb, but was not configured in our integration.
any chance we can log that instead if |
This was referenced Mar 12, 2024
This was referenced May 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
errorHandler
forCanvasManager
was added in the latest rrweb, but was not configured in our integration.