Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(performance): create Interaction standalone spans on inp events #10709

Merged
merged 37 commits into from Feb 29, 2024
Merged

feat(performance): create Interaction standalone spans on inp events #10709

merged 37 commits into from Feb 29, 2024

Commits on Feb 18, 2024

  1. Merge branch 'egou/v7/feat/add-span-envelope-and-datacategory' of git… 

    …hub.com:getsentry/sentry-javascript into egou/v7/feat/add-span-envelope-and-datacategory
    @edwardgou-sentry
    edwardgou-sentry committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    2d83f03 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'egou/v7/feat/add-exclusive-time-and-measurements-to-spa… 

    …ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/add-span-envelope-and-datacategory
    @edwardgou-sentry
    edwardgou-sentry committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    abe1bc2 View commit details
    Browse the repository at this point in the history

  3. Creates interaction spans with inp when inp is detected

    @edwardgou-sentry
    edwardgou-sentry committed Feb 18, 2024
    Configuration menu
    Copy the full SHA
    9ae7f95 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2024

  1. Adds sampling rate to inp spans

    @edwardgou-sentry
    edwardgou-sentry committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    84a6021 View commit details
    Browse the repository at this point in the history

  2. export isValidSampleRate

    @edwardgou-sentry
    edwardgou-sentry committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6bd6ff8 View commit details
    Browse the repository at this point in the history

Commits on Feb 21, 2024

  1. Merge branch 'v7' of github.com:getsentry/sentry-javascript into egou… 

    …/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    97ece4e View commit details
    Browse the repository at this point in the history

  2. Merge branch 'egou/v7/fix/browser-tracing-latest-route' of github.com… 

    …:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    ccd8ec1 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'egou/v7/feat/add-exclusive-time-and-measurements-to-spa… 

    …ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    b2e4656 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'egou/v7/feat/add-span-envelope-and-datacategory' of git… 

    …hub.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 21, 2024
    Configuration menu
    Copy the full SHA
    5d53fa4 View commit details
    Browse the repository at this point in the history

Commits on Feb 22, 2024

  1. Merge branch 'egou/v7/feat/create-interaction-spans-on-inp' of github… 

    ….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
    @edwardgou-sentry
    edwardgou-sentry committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    c2aa318 View commit details
    Browse the repository at this point in the history

  2. fix

    @edwardgou-sentry
    edwardgou-sentry committed Feb 22, 2024
    Configuration menu
    Copy the full SHA
    5ee3045 View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Merge branch 'egou/v7/feat/add-span-envelope-and-datacategory' of git… 

    …hub.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    9e24b2b View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. snake case

    @edwardgou-sentry
    edwardgou-sentry committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    690ecc1 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'egou/v7/feat/create-interaction-spans-on-inp' of github… 

    ….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
    @edwardgou-sentry
    edwardgou-sentry committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a937852 View commit details
    Browse the repository at this point in the history

Commits on Feb 28, 2024

  1. Adds profile id, replay id, and user to standalone INP spans if they … 

    …exist
    @edwardgou-sentry
    edwardgou-sentry committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    0559eab View commit details
    Browse the repository at this point in the history

  2. htmlTreeAsString span name

    @edwardgou-sentry
    edwardgou-sentry committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    9b6d5a7 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'v7' of github.com:getsentry/sentry-javascript into egou… 

    …/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    6fddd84 View commit details
    Browse the repository at this point in the history

  4. Merge branch 'egou/v7/feat/add-exclusive-time-and-measurements-to-spa… 

    …ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    19cf74a View commit details
    Browse the repository at this point in the history

  5. pull profile id from attributes into top level because relay expects … 

    …this
    @edwardgou-sentry
    edwardgou-sentry committed Feb 28, 2024
    Configuration menu
    Copy the full SHA
    bbdc8f0 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. refactor out some optional chaining

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    e5f21ab View commit details
    Browse the repository at this point in the history

  2. Merge branch 'egou/v7/feat/add-exclusive-time-and-measurements-to-spa… 

    …ns' of github.com:getsentry/sentry-javascript into egou/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9a1b12e View commit details
    Browse the repository at this point in the history

  3. update span creation

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    77f610b View commit details
    Browse the repository at this point in the history

  4. Merge branch 'egou/v7/feat/create-interaction-spans-on-inp' of github… 

    ….com:getsentry/sentry-javascript into egou/v7/feat/add-sampling-rate-to-inp-spans
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    05f55f1 View commit details
    Browse the repository at this point in the history

  5. refactor optional check

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    d943c8d View commit details
    Browse the repository at this point in the history

  6. Merge branch 'v7' of github.com:getsentry/sentry-javascript into egou… 

    …/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9e04846 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'egou/v7/feat/add-sampling-rate-to-inp-spans' of github.… 

    …com:getsentry/sentry-javascript into egou/v7/profile-replay-and-user-for-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    8b929bc View commit details
    Browse the repository at this point in the history

  8. increase size limit by 1 kb

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    059508c View commit details
    Browse the repository at this point in the history

  9. todo comment and update interactionIdtoRouteNameMapping replay to rep… 

    …layid
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    65bb1ac View commit details
    Browse the repository at this point in the history

  10. comment

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    9782eaf View commit details
    Browse the repository at this point in the history

  11. fix import

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    ac749fb View commit details
    Browse the repository at this point in the history

  12. feat(webvitals): Add profile id, replay id, and user to standalone IN… 

    …P spans (#10849)

Adds profile id, replay id, and user to standalone INP spans.

User comes from the current scope.
Replay Id is retrieved from the relay integration module and calling getReplayId().
Profile Id is retrieved from getting the active transaction at the time of the interaction
Since profile id isn't added to the transaction until the transaction ends, we need to hold onto a reference to the transaction instead of trying to grab the profile id right away
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3336ff3 View commit details
    Browse the repository at this point in the history

  13. feat(performance): Add sampling rate to INP spans. Also add replay id… 

    …, profile id, and user.

Updates INP spans to check for sampling rate, similar to transactions.
Also Adds profile id, replay id, and user to standalone INP spans.

User comes from the current scope.
Replay Id is retrieved from the relay integration module and calling getReplayId().
Profile Id is retrieved from getting the active transaction at the time of the interaction
Since profile id isn't added to the transaction until the transaction ends, we need to hold onto a reference to the transaction instead of trying to grab the profile id right away
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    b515f8e View commit details
    Browse the repository at this point in the history

  14. Merge branch 'v7' of github.com:getsentry/sentry-javascript into egou… 

    …/v7/feat/create-interaction-spans-on-inp
    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    93f5c19 View commit details
    Browse the repository at this point in the history

  15. move enableInp off experiment

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    a3f235f View commit details
    Browse the repository at this point in the history

  16. performanceeventtiming interface

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    5807e2d View commit details
    Browse the repository at this point in the history

  17. interactionId

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    226c543 View commit details
    Browse the repository at this point in the history

  18. use more primitive types

    @edwardgou-sentry
    edwardgou-sentry committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    fc676fc View commit details
    Browse the repository at this point in the history