Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): Add LRU map for tracePropagationTargets calculation #8130

Merged
merged 1 commit into from May 16, 2023

Conversation

AbhiPrasad
Copy link
Member

fixes #8129

Adds an LRU Map so that we don't let the cached items grow infinitely.

Important to note that shouldAttachTraceData and shouldCreateSpan behaviour is basically identical now other than the map and executor used, but I didn't refactor further because I felt the abstraction is more confusing than just having this simple duplication.

@AbhiPrasad AbhiPrasad requested review from a team, stephanie-anderson and Lms24 and removed request for a team May 16, 2023 08:56
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
@sentry/browser - ES5 CDN Bundle (gzipped + minified) 21.03 KB (+0.04% 🔺)
@sentry/browser - ES5 CDN Bundle (minified) 65.63 KB (+0.02% 🔺)
@sentry/browser - ES6 CDN Bundle (gzipped + minified) 19.57 KB (+0.04% 🔺)
@sentry/browser - ES6 CDN Bundle (minified) 58.09 KB (+0.02% 🔺)
@sentry/browser - Webpack (gzipped + minified) 21.17 KB (0%)
@sentry/browser - Webpack (minified) 69.04 KB (0%)
@sentry/react - Webpack (gzipped + minified) 21.19 KB (0%)
@sentry/nextjs Client - Webpack (gzipped + minified) 49.12 KB (+0.01% 🔺)
@sentry/browser + @sentry/tracing - ES5 CDN Bundle (gzipped + minified) 28.65 KB (+0.04% 🔺)
@sentry/browser + @sentry/tracing - ES6 CDN Bundle (gzipped + minified) 26.89 KB (+0.05% 🔺)
@sentry/replay ES6 CDN Bundle (gzipped + minified) 48.13 KB (+1.09% 🔺)
@sentry/replay - Webpack (gzipped + minified) 42.02 KB (+1.35% 🔺)
@sentry/browser + @sentry/tracing + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 67.09 KB (+0.88% 🔺)
@sentry/browser + @sentry/replay - ES6 CDN Bundle (gzipped + minified) 59.99 KB (+1.02% 🔺)

@AbhiPrasad AbhiPrasad merged commit 0eb81bc into develop May 16, 2023
43 checks passed
@AbhiPrasad AbhiPrasad deleted the abhi-add-lru-map branch May 16, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node HTTP integration memory leak
3 participants