Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(v7): Deprecate addRequestDataToTransaction #11368

Merged
merged 1 commit into from Apr 2, 2024

Conversation

mydea
Copy link
Member

@mydea mydea commented Apr 2, 2024

This is not used/needed anymore in v8, and also is coupled to transactions.

Not sure if we need to add this to migration docs, as this is from utils and was more internally used...? (Also, I guess if so we need to add it to migration docs in a separate PR on develop...?)

This is not used/needed anymore in v8, and also is coupled to transactions.
Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Utils package technically doesn't even guarantee semver so I think this is perfectly fine!

@mydea mydea merged commit fdcd1ad into v7 Apr 2, 2024
103 checks passed
@mydea mydea deleted the fn/deprecate-addRequestDataToTransaction branch April 2, 2024 11:40
AbhiPrasad pushed a commit that referenced this pull request Apr 2, 2024
See #11368, where
this is deprecated on v7.
cadesalaberry pushed a commit to cadesalaberry/sentry-javascript that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants