Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(replay): Add errorHandler for replayCanvas integration #10796

Merged
merged 3 commits into from Feb 29, 2024

Conversation

billyvg
Copy link
Member

@billyvg billyvg commented Feb 22, 2024

errorHandler for CanvasManager was added in the latest rrweb, but was not configured in our integration.

`errorHandler` for `CanvasManager` was added in the latest rrweb, but was not configured in our integration.
Copy link
Contributor

github-actions bot commented Feb 22, 2024

size-limit report 📦

Path Size
@sentry/browser (incl. Tracing, Replay, Feedback) - Webpack (gzipped) 77.3 KB (+0.04% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack (gzipped) 68.56 KB (+0.03% 🔺)
@sentry/browser (incl. Tracing, Replay with Canvas) - Webpack (gzipped) 72.49 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - Webpack with treeshaking flags (gzipped) 62.06 KB (+0.02% 🔺)
@sentry/browser (incl. Tracing) - Webpack (gzipped) 32.74 KB (+0.07% 🔺)
@sentry/browser (incl. browserTracingIntegration) - Webpack (gzipped) 32.74 KB (+0.07% 🔺)
@sentry/browser (incl. Feedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser (incl. sendFeedback) - Webpack (gzipped) 30.91 KB (0%)
@sentry/browser - Webpack (gzipped) 22.19 KB (0%)
@sentry/browser (incl. Tracing, Replay, Feedback) - ES6 CDN Bundle (gzipped) 75.71 KB (-0.06% 🔽)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (gzipped) 67.47 KB (-0.04% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (gzipped) 33.25 KB (-0.11% 🔽)
@sentry/browser - ES6 CDN Bundle (gzipped) 24.74 KB (+0.06% 🔺)
@sentry/browser (incl. Tracing, Replay) - ES6 CDN Bundle (minified & uncompressed) 211.07 KB (-0.1% 🔽)
@sentry/browser (incl. Tracing) - ES6 CDN Bundle (minified & uncompressed) 99.79 KB (-0.21% 🔽)
@sentry/browser - ES6 CDN Bundle (minified & uncompressed) 73.96 KB (+0.25% 🔺)
@sentry/browser (incl. Tracing) - ES5 CDN Bundle (gzipped) 36.3 KB (-0.15% 🔽)
@sentry/react (incl. Tracing, Replay) - Webpack (gzipped) 68.84 KB (+0.04% 🔺)
@sentry/react - Webpack (gzipped) 22.22 KB (0%)
@sentry/nextjs Client (incl. Tracing, Replay) - Webpack (gzipped) 85.3 KB (+0.06% 🔺)
@sentry/nextjs Client - Webpack (gzipped) 49.68 KB (+0.05% 🔺)
@sentry-internal/feedback - Webpack (gzipped) 17.14 KB (0%)

@billyvg billyvg marked this pull request as ready for review February 27, 2024 18:49
@billyvg billyvg requested review from c298lee, a team and mydea February 27, 2024 18:49
@billyvg billyvg merged commit ca90331 into develop Feb 29, 2024
92 checks passed
@billyvg billyvg deleted the fix-replay-canvas-manager-needs-error-handler branch February 29, 2024 16:13
AbhiPrasad pushed a commit that referenced this pull request Feb 29, 2024
`errorHandler` for `CanvasManager` was added in the latest rrweb, but
was not configured in our integration.
@bruno-garcia
Copy link
Member

any chance we can log that instead if debug:true?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants